Skip to content

Fix dist_approx with "geosphere" method and close points #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
emanuel-schmid merged 3 commits into from
Oct 30, 2023
Merged

Fix dist_approx with "geosphere" method and close points #792

emanuel-schmid merged 3 commits into from
Oct 30, 2023

Conversation

@tovogt
Copy link
Collaborator

@tovogt tovogt commented Oct 18, 2023 •
edited
Loading

Changes proposed in this PR:

  • Fix the dist_approx util function when used with method="geosphere" and log=True.
  • This only affects very small input values, i.e. computing the distance between points that are very close. I added a unit test for that case. I also added a test case where points are identical because I think that this is a kind of sanity check that should be included.

PR Author Checklist

PR Reviewer Checklist

@tovogt tovogt changed the title Feature/fix dist approx geosphere Fix dist_approx with "geosphere" method and close points Oct 18, 2023
@chahank chahank requested a review from viggowat October 18, 2023 09:38
emanuel-schmid
emanuel-schmid reviewed Oct 24, 2023
View reviewed changes
@emanuel-schmid
Copy link
Collaborator

emanuel-schmid commented Oct 24, 2023

Looks good to me. Obviously fixes a bug.

@emanuel-schmid emanuel-schmid merged commit f362c2b into develop Oct 30, 2023
@emanuel-schmid emanuel-schmid deleted the feature/fix_dist_approx_geosphere branch October 30, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emanuel-schmid emanuel-schmid emanuel-schmid left review comments

@viggowat viggowat Awaiting requested review from viggowat

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tovogt @emanuel-schmid