Skip to content

Tag Removal Modules Structure Rearranged #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
emanuel-schmid merged 5 commits into from
Sep 1, 2023
Merged

Tag Removal Modules Structure Rearranged #779

emanuel-schmid merged 5 commits into from
Sep 1, 2023

Conversation

@emanuel-schmid
Copy link
Collaborator

@emanuel-schmid emanuel-schmid commented Aug 31, 2023 •
edited
Loading

Changes proposed in this PR:

  • removal of hazard.tag and hazard.test.test_tag
  • move util.tag and util.test.test_tag into entity.tag
  • changelog: consolidation of changes related to the tag removal from climada

PR Author Checklist

PR Reviewer Checklist

@emanuel-schmid emanuel-schmid changed the title Feature/remove tag class Tag Removal Modules Structure Rearranged Aug 31, 2023
@emanuel-schmid emanuel-schmid requested review from chahank and peanutfun and removed request for peanutfun August 31, 2023 09:33
@emanuel-schmid
Copy link
Collaborator Author

emanuel-schmid commented Aug 31, 2023 •
edited
Loading

@chahank @peanutfun : The file structure should be fine (enough), but please check the changelog.

@emanuel-schmid emanuel-schmid merged commit 00e1e7e into develop Sep 1, 2023
@emanuel-schmid emanuel-schmid deleted the feature/remove_tag_class branch September 1, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chahank chahank Awaiting requested review from chahank chahank is a code owner

@peanutfun peanutfun Awaiting requested review from peanutfun peanutfun is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@emanuel-schmid