Skip to content

Remove pandas append to concat #777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
emanuel-schmid merged 1 commit into from
Aug 30, 2023
Merged

Remove pandas append to concat #777

emanuel-schmid merged 1 commit into from
Aug 30, 2023

Conversation

@chahank
Copy link
Member

@chahank chahank commented Aug 29, 2023

Changes proposed in this PR:

  • Solves upgrade pandas 1.5 -> 2.0
  • Replace gdf.append with pd.concat.

This PR fixes #700

PR Author Checklist

PR Reviewer Checklist

@chahank chahank requested a review from emanuel-schmid August 29, 2023 08:18
@emanuel-schmid
Copy link
Collaborator

emanuel-schmid commented Aug 30, 2023

👍 🙌

@emanuel-schmid emanuel-schmid merged commit 39c8eb1 into develop Aug 30, 2023
@emanuel-schmid emanuel-schmid deleted the fix/remove_df_append branch August 30, 2023 07:48
@chahank chahank mentioned this pull request Aug 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emanuel-schmid emanuel-schmid Awaiting requested review from emanuel-schmid emanuel-schmid is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chahank @emanuel-schmid