Skip to content

Conversation

@emanuel-schmid
Copy link
Collaborator

@emanuel-schmid emanuel-schmid commented Jul 12, 2023

Changes proposed in this PR:

  • simply remove the attribute, leaving out any descriptions when initializing an object

This PR fixes #

PR Author Checklist

PR Reviewer Checklist

Copy link
Member

@peanutfun peanutfun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I found the section printing help(DiscRates) in the tutorial quite unnecessary and now added a link to the docs, where one can find the exact same information, but with better formatting. @chahank @emanuel-schmid, do you approve? (see 181b494)

@peanutfun peanutfun requested a review from chahank July 12, 2023 14:42
@chahank
Copy link
Member

chahank commented Jul 12, 2023

Looks good to me (if all the tests pass).

@emanuel-schmid emanuel-schmid merged commit dd70ca4 into develop Jul 12, 2023
@emanuel-schmid
Copy link
Collaborator Author

thanks for reviewing

@emanuel-schmid emanuel-schmid deleted the feature/remove_tags_discrates branch July 12, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants