Skip to content

TCTracks.from_simulations_emanuel: optionally, only load a subset #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tovogt merged 11 commits into from
Jul 3, 2023
Merged

TCTracks.from_simulations_emanuel: optionally, only load a subset #741

tovogt merged 11 commits into from
Jul 3, 2023

Conversation

@tovogt
Copy link
Collaborator

@tovogt tovogt commented Jun 27, 2023 •
edited
Loading

Changes proposed in this PR:

  • Small feature that allows to read a subset of a track data set instead of the whole file. Since the simulation data sets can be quite huge, it's a pain having to read everything, even if you're only interested in a (random) sub-sample.
  • Also, fixes a bug where the "time_step" variable was stored as an integer which caused problems when interpolating to sub-hourly resolutions.

PR Author Checklist

PR Reviewer Checklist

@tovogt tovogt mentioned this pull request Jun 29, 2023
Merged
13 tasks
emanuel-schmid
emanuel-schmid reviewed Jul 3, 2023
View reviewed changes
emanuel-schmid
emanuel-schmid reviewed Jul 3, 2023
View reviewed changes
@emanuel-schmid
Copy link
Collaborator

emanuel-schmid commented Jul 3, 2023

🙌 ready to merge

@tovogt tovogt merged commit e96793a into develop Jul 3, 2023
@tovogt tovogt deleted the feature/tc_tracks_emanuel_subset branch July 20, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emanuel-schmid emanuel-schmid emanuel-schmid left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tovogt @emanuel-schmid