Skip to content

Deprecate superfluous classmethods of Centroids #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chahank merged 4 commits into from
May 15, 2023
Merged

Deprecate superfluous classmethods of Centroids #721

chahank merged 4 commits into from
May 15, 2023

Conversation

@peanutfun
Copy link
Member

@peanutfun peanutfun commented May 12, 2023 •
edited
Loading

Changes proposed in this PR:

  • Deprecate Centroids.from_geodataframe and Centroids.from_pix_bounds
  • Delete Centroids.set_raster_from_pix_bounds

Prepares for #698

PR Author Checklist

PR Reviewer Checklist

@peanutfun peanutfun marked this pull request as ready for review May 12, 2023 12:14
@chahank
Copy link
Member

chahank commented May 12, 2023

Good idea for simplifying the code. I would maybe just note somewhere that only regular grids will be supported (from_pix_bounds did also support grids with different x/y resolutions).

@peanutfun
Copy link
Member Author

peanutfun commented May 12, 2023

@chahank Done!

@chahank chahank merged commit 76d6d36 into develop May 15, 2023
@peanutfun peanutfun mentioned this pull request May 15, 2023
Open
@emanuel-schmid emanuel-schmid deleted the deprecate-centroids-classmethods branch May 25, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chahank chahank Awaiting requested review from chahank chahank is a code owner

@emanuel-schmid emanuel-schmid Awaiting requested review from emanuel-schmid emanuel-schmid is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@peanutfun @chahank