Skip to content

Feature/fix nightlight test #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
emanuel-schmid merged 7 commits into from
May 15, 2023
Merged

Feature/fix nightlight test #718

emanuel-schmid merged 7 commits into from
May 15, 2023

Conversation

@emanuel-schmid
Copy link
Collaborator

@emanuel-schmid emanuel-schmid commented May 10, 2023

Changes proposed in this PR:

This PR fixes #

PR Author Checklist

PR Reviewer Checklist

@NicolasColombi
fix test_load_nightlight_noaa
859ac8f 
The test was failing the integration check on jenkins.
Create fake .tif.gz file, execute test, delate.tif.gz file.
@NicolasColombi
formatting
c911e0b
@emanuel-schmid emanuel-schmid marked this pull request as draft May 10, 2023 08:04
@emanuel-schmid emanuel-schmid mentioned this pull request May 12, 2023
Merged
13 tasks
@NicolasColombi
formatting
65734df 
change sat_name from 'F18' to 'E99'
@NicolasColombi
Copy link
Collaborator

NicolasColombi commented May 12, 2023

Hi @emanuel-schmid Thanks for checking and delating the file!
The data comes from the noaa website, but in our test we create a fake .tif.gz file and delate it afterwords.
I changed the sat_name from F18 to E99 and applied your formatting suggestions, without the .p file on jenkins wall the test should pass know 🤞
Let me know if there are still problems,
Thanks again!

@emanuel-schmid
Copy link
Collaborator Author

emanuel-schmid commented May 15, 2023 •
edited
Loading

Thanks a lot! 😄 I've did some minor cosmetics and added a line that deletes the **.p file in case the previous test run failed in the middle and didn't clean up after itself.

@emanuel-schmid emanuel-schmid marked this pull request as ready for review May 15, 2023 11:12
@emanuel-schmid emanuel-schmid merged commit 5234fa6 into develop May 15, 2023
@emanuel-schmid emanuel-schmid deleted the feature/fix_nightlight_test branch May 15, 2023 11:12
@NicolasColombi
Copy link
Collaborator

NicolasColombi commented May 16, 2023

Thank you @emanuel-schmid! Good Idea to add a line in case the test fails!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@NicolasColombi NicolasColombi

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@emanuel-schmid @NicolasColombi