-
Notifications
You must be signed in to change notification settings - Fork 149
Avoid Impact storing a pyproj.CRS object
#713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ChrisFairless could you check if this resolves your issue? Instead of storing |
|
Yes this looks good! Thanks for the fix. I like how the WKT is recognised by |
|
Agreed. In my experience, WKT is the one that gives the least amount of warnings. 😁
|
|
I'll patch that. |
|
@emanuel-schmid Fixed handling of |
|
Many thanks! To me it's fine for merging, I've added a changlog entry. Feel free to edit. |
|
@emanuel-schmid How should we handle the erroneous pylint issue here: https://github.com/CLIMADA-project/climada_python/pull/713/files#diff-1c276908f04d1a0ca5b1692295a586ce54b0937673711203582d3d72099ecdd0R45 ? |
|
🤷 I's just suppress it for this particular line by adding |
Changes proposed in this PR:
pyproj.CRSinto WKT string inImpact.__init__. WKT is the most precise form of storing CRS information, apart from an actualCRSobject. This should work fine as theImpact.crsattribute can now safely be stored as string, and inserting the WKT into theExposuresconstructor is supported.This PR fixes #706
PR Author Checklist
develop)PR Reviewer Checklist