-
Notifications
You must be signed in to change notification settings - Fork 149
Add section to Guide_CLIMADA_Tutorial.ipynb #668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add a section in the guide doc/guide/Guide_CLIMADA_Tutorial.ipynb that specify to only use markdown instead of html to create tutorials.
| "\n", | ||
| "- follow the general CLIMADA naming convention for the notebook. For example: \"climada_hazard_TropCyclone.ipynb\"\n", | ||
| "\n", | ||
| "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not part of this pull request, but why do we have this image here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question, I do not really know.. shall I remove it ? I added a space just because it was attached to the text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, let us remove it.
| "2.\n", | ||
| "\n", | ||
| "\n", | ||
| "Lastly, the table of content should only contain headers of level 2 (##). Remember that links to headers are case sensitive!\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably here indicate what "links to headers" are? How does one know what is the correct link for a given header?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a few sentences to explain it, it should be more explicit now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect.
|
Thanks, very useful! |
Co-authored-by: Chahan M. Kropf <chahan.kropf@usys.ethz.ch>
…roject/climada_python into feature/guide_tutorial
| "source": [ | ||
| "### Input:\n", | ||
| "\n", | ||
| "\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice picture - but I have trouble reading it (need to zoom in).
Wouldn't it be more useful to have it as plain text instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emanuel-schmid I agree it would be better with just text. I just didn't know how to write it without rendering the output. Since it is Markdown, it is interpreted as such and therefore converted to a table. Do you know how to write Markdown syntax without rendering the output ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NicolasColombi : yes 😉 have a look at the changed guide
doc/guide/Guide_Continuous_Integration_and_Testing.ipynb
|
@emanuel-schmid : I think this is ready to merge right? |
Changes proposed in this PR:
PR Author Checklist
develop)PR Reviewer Checklist