Skip to content

Conversation

@NicolasColombi
Copy link
Collaborator

@NicolasColombi NicolasColombi commented Mar 1, 2023

Changes proposed in this PR:

  • Add a section in the guide doc/guide/Guide_CLIMADA_Tutorial.ipynb that specify to only use markdown instead of html to create tutorials.
  • Add an image of 46.7 KB

PR Author Checklist

PR Reviewer Checklist

Add a section in the guide doc/guide/Guide_CLIMADA_Tutorial.ipynb that
specify to only use markdown instead of html to create tutorials.
@NicolasColombi NicolasColombi marked this pull request as ready for review March 1, 2023 14:36
@NicolasColombi NicolasColombi requested a review from chahank March 1, 2023 14:37
"\n",
"- follow the general CLIMADA naming convention for the notebook. For example: \"climada_hazard_TropCyclone.ipynb\"\n",
"\n",
"![image-2.png](attachment:image-2.png)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not part of this pull request, but why do we have this image here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, I do not really know.. shall I remove it ? I added a space just because it was attached to the text.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let us remove it.

"2.\n",
"\n",
"\n",
"Lastly, the table of content should only contain headers of level 2 (##). Remember that links to headers are case sensitive!\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably here indicate what "links to headers" are? How does one know what is the correct link for a given header?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few sentences to explain it, it should be more explicit now

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect.

@chahank
Copy link
Member

chahank commented Mar 2, 2023

Thanks, very useful!

"source": [
"### Input:\n",
"\n",
"![](img/Table_content.png)\n",
Copy link
Collaborator

@emanuel-schmid emanuel-schmid Mar 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice picture - but I have trouble reading it (need to zoom in).
Wouldn't it be more useful to have it as plain text instead?

Copy link
Collaborator Author

@NicolasColombi NicolasColombi Mar 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emanuel-schmid I agree it would be better with just text. I just didn't know how to write it without rendering the output. Since it is Markdown, it is interpreted as such and therefore converted to a table. Do you know how to write Markdown syntax without rendering the output ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NicolasColombi : yes 😉 have a look at the changed guide

doc/guide/Guide_Continuous_Integration_and_Testing.ipynb
@chahank
Copy link
Member

chahank commented Mar 28, 2023

@emanuel-schmid : I think this is ready to merge right?

@emanuel-schmid emanuel-schmid merged commit 20754b1 into develop Mar 29, 2023
@emanuel-schmid emanuel-schmid deleted the feature/guide_tutorial branch March 29, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants