Skip to content

Conversation

@timschmi95
Copy link
Collaborator

@timschmi95 timschmi95 commented Jul 4, 2025

This PR adds minor changes from the joint tutorial review, specifically for the data API tutorial. Overall, it looks good and still runs through smoothly. The following minor changes were added:

  • Changed text to account for the default selection of the latitude extent -60 to 60 in client.get_centroids()
  • Removed text reference to renamed function get_datasets() to into_datasets_df()
  • (?) Removed obsolete property nb_synth_tracks from the TC hazard download
  • Minor formatting updates in some of the markdown cells.

PR Author Checklist

PR Reviewer Checklist

@timschmi95
Copy link
Collaborator Author

@emanuel-schmid Please have a look at the changes. In particular, if there are any new data API features that should also be discussed in the tutorial.
And regarding the removal of the nb_synth_tracks from the TC hazard download: Do I see this correctly that this property has been removed because it is always 10 for synthetic datasets and always 1 for historic?

@timschmi95
Copy link
Collaborator Author

Also, does such a minor change still require a changelog update? If so, I'll be happy to add it.

@timschmi95
Copy link
Collaborator Author

@spjuhel, this is the PR for the data API tutorial (you said we should tag you, right?)

@timschmi95
Copy link
Collaborator Author

A note on recreated plots: 3 of 4 plots changed (the hazard plot uses the new interpolation function from the recent PR #1047, and the two centroids plots essentially switched places, because the default extent has changed).
@emanuel-schmid if the repository size is a big issue, I could redo the changes without running the cell which produces the only unchanged plot, but the remaining 3 would still be changed. Otherwise, I would keep it as is.

@emanuel-schmid
Copy link
Collaborator

@timschmi95 many thanks! Looks much better now. Feel free to merge.

@timschmi95 timschmi95 merged commit 5d711a2 into develop Sep 25, 2025
19 checks passed
@timschmi95 timschmi95 deleted the feature/review_api_tutorial branch September 25, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants