-
Notifications
You must be signed in to change notification settings - Fork 149
Closed
Labels
accepting pull requestContribute by raising a pull request to resolve this issue!Contribute by raising a pull request to resolve this issue!enhancement
Description
Is your feature request related to a problem? Please describe.
The documentation of Hazard and Impact states that the event_name attribute is supposed to be a list of strings. However, this is never enforced within the code base. In particular, some unit tests actually check if "mixed-type" lists work. In #894, we decided that
- a write method should not proceed if
event_namecontains other values than strings - a read method should warn if
event_nameis not stored as strings and try to convert the values to strings.
Describe the solution you'd like
Apply the above decisions to all readers and writers of Hazard and Impact.
Describe alternatives you've considered
- Converting any
event_namevalues to strings before writing might lead to nonsense, see Explicitly convertevent_nameto strings inImpact.from_hdf5#894 (comment). Therefore, writing non-stringevent_namevalues should fail.
Additional context
None
Metadata
Metadata
Assignees
Labels
accepting pull requestContribute by raising a pull request to resolve this issue!Contribute by raising a pull request to resolve this issue!enhancement