fix: bundle name may be stripped to empty string#87
Merged
CLARATION merged 2 commits intoCLARATION:mainfrom Jan 17, 2026
Merged
fix: bundle name may be stripped to empty string#87CLARATION merged 2 commits intoCLARATION:mainfrom
CLARATION merged 2 commits intoCLARATION:mainfrom
Conversation
Owner
|
I actually didn't consider that apps may never have ascii characters for their display name, this is a good catch :) |
CLARATION
reviewed
Jan 17, 2026
Owner
|
oh yeah forgot, thank you very much :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_name()retrieves the display name first. Some apps may use CJK characters for the display name, this will be stripped to an empty string when callingqh_add_app_id(), and resulting in an API error.