Skip to content

Clean up CH3::do_intersect#9383

Merged
sloriot merged 8 commits intoCGAL:mainfrom
sloriot:CH3-do_intersect_clean_up
Apr 1, 2026
Merged

Clean up CH3::do_intersect#9383
sloriot merged 8 commits intoCGAL:mainfrom
sloriot:CH3-do_intersect_clean_up

Conversation

@sloriot
Copy link
Copy Markdown
Member

@sloriot sloriot commented Mar 18, 2026 •
edited
Loading

Follow up of #6557

  • do not inherit from std::vector
  • the function introduced in the kernel does not really makes sense as the real usage is not based on vector but 2 points and 1 direction.

@sloriot sloriot added this to the 6.2-beta milestone Mar 18, 2026
sloriot
sloriot commented Mar 23, 2026
View reviewed changes
@sloriot sloriot added Not yet approved The feature or pull-request has not yet been approved. Tested CHANGES.md not updated and removed Under Testing labels Mar 24, 2026
@sloriot
Copy link
Copy Markdown
Member Author

sloriot commented Mar 24, 2026

Successfully tested in CGAL-6.2-Ic-137

@github-actions github-actions bot removed the Tested label Mar 26, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 26, 2026

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

@sloriot
Copy link
Copy Markdown
Member Author

sloriot commented Mar 30, 2026

Successfully tested in CGAL-6.2-Ic-141

@sloriot sloriot added Tested and removed Under Testing Not yet approved The feature or pull-request has not yet been approved. labels Mar 30, 2026
@github-actions github-actions bot removed the Tested label Mar 30, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 30, 2026

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

@sloriot sloriot force-pushed the CH3-do_intersect_clean_up branch from 4d0da08 to 77a234f Compare March 30, 2026 13:37
@lrineau lrineau added the rm only: release blocker For the release team only: the next release requires this issue/PR to be solved/merge label Mar 30, 2026
@sloriot
Copy link
Copy Markdown
Member Author

sloriot commented Apr 1, 2026

Successfully tested in CGAL-6.2-Ic-144

@sloriot sloriot merged commit a3e5596 into CGAL:main Apr 1, 2026
1 check passed
@MaelRL MaelRL mentioned this pull request Apr 2, 2026
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaelRL MaelRL MaelRL left review comments

Assignees

No one assigned

Labels

Cleaning Pkg::Convex_hull_3 rm only: release blocker For the release team only: the next release requires this issue/PR to be solved/merge Tested

Projects

None yet

Milestone

6.2-beta

Development

Successfully merging this pull request may close these issues.

3 participants

@sloriot @MaelRL @lrineau