patch to support PowerPC and Windows 32 bits#7635
Conversation
|
Shouldn't you patch Currently the condition is Maybe you can use |
|
There is also a similar issue with the Conda CI, on a |
Maybe. That would fix also the bug for users not using our CMake scripts. I was more comfortable with a patch in CMake.
https://learn.microsoft.com/en-us/cpp/preprocessor/predefined-macros?
Maybe |
|
I have a new patch. Please review cf0c6c0. |
|
@mglisse #ifdef _WIN64
_BitScanForward64(&r, x);
#else
if (_BitScanForward(&r, (uint32_t)(x >> 32))) {
r += 32;
} else {
_BitScanForward(&r, (uint32_t)x);
}
#endifWould the rest of |
|
Successfully tested in CGAL-6.0-Ic-39 |
Summary of Changes
Patch required for the acceptance of CGAL-5.6 in vcpkg. The CI system tests on
x86_windows(32 bits), and there was an error:See microsoft/vcpkg#32896 (comment)
The solution is do disable support for Boost MP on Windows 32 bits. That patch has been tested with the vcpkg CI, and it worked.
Release Management