Skip to content

Surf_reader : Enhancement#4674

Merged
sloriot merged 2 commits intoCGAL:masterfrom
maxGimeno:Surf_reader_enhancement-maxGimeno
Apr 27, 2020
Merged

Surf_reader : Enhancement#4674
sloriot merged 2 commits intoCGAL:masterfrom
maxGimeno:Surf_reader_enhancement-maxGimeno

Conversation

@maxGimeno
Copy link
Copy Markdown
Contributor

Summary of Changes

Enhancement for our surf_reader

Release Management

  • Affected package(s):Polyhedron_demo

@maxGimeno maxGimeno added this to the 5.1-beta milestone Apr 21, 2020
@maxGimeno maxGimeno self-assigned this Apr 21, 2020
@maxGimeno maxGimeno mentioned this pull request Apr 21, 2020
66 tasks
@janetournois
Copy link
Copy Markdown
Member

It works for me, thank you!

@janetournois
Copy link
Copy Markdown
Member

Hi @maxGimeno

there is another problem with our surf reader and the input file I gave you.
The file is read and the demo displays the polyhedral surface, but inside out, and the console displays :

732 vertices
1 patch(es)
The patch #0:
  -inner region : material's id = 0 material's name = Exterior
  -outer region: material's id = 1 material's name = Material1

Can you please make sure "exterior" corresponds to "outer region"?

@maxGimeno
Copy link
Copy Markdown
Contributor Author

The input file explicitly define the inner region as "exterior" :/

@janetournois
Copy link
Copy Markdown
Member

Actually the file defines :

InnerRegion Exterior
OuterRegion Material1

so the inconsistency is in the input.
Let's keep it this way, thank you!

@maxGimeno
Copy link
Copy Markdown
Contributor Author

@sloriot sloriot self-assigned this Apr 27, 2020
@sloriot sloriot merged commit ffd682c into CGAL:master Apr 27, 2020
@sloriot sloriot deleted the Surf_reader_enhancement-maxGimeno branch April 27, 2020 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants