Skip to content

Read PLY polygon soup#2249

Merged
sloriot merged 22 commits intoCGAL:masterfrom
sgiraudot:Read_PLY_polygon_soup-GF
Aug 10, 2017
Merged

Read PLY polygon soup#2249
sloriot merged 22 commits intoCGAL:masterfrom
sgiraudot:Read_PLY_polygon_soup-GF

Conversation

@sgiraudot
Copy link
Copy Markdown
Contributor

@sgiraudot sgiraudot commented Jul 11, 2017

Summary of Changes

This is a first step for solving the issue #2196:

  • it adds some (internal) needed methods/functions in the existing PLY headers (in point set processing)
  • it adds functions to read/write PLY polygon soups (and to write face graphs)
  • it adds mesh polygon soup support to the PLY plugin

So far, this PR only modifies internal code and demo code. To fully solve the issue #2196, there should also be a small feature to document read_OFF() and these new PLY functions.

Release Management

@lrineau
Copy link
Copy Markdown
Member

lrineau commented Jul 12, 2017

There is a Travis build error: https://travis-ci.org/CGAL/cgal/jobs/252398163#L4568

Do you reproduce it locally?

@sgiraudot
Copy link
Copy Markdown
Contributor Author

sgiraudot commented Jul 12, 2017

Yes, it should be fixed now.

@lrineau lrineau added this to the 4.12-beta milestone Jul 12, 2017
@lrineau
Copy link
Copy Markdown
Member

lrineau commented Jul 12, 2017

I have selected CGAL-4.12 for this PR, unless we have good reason for force its way into CGAL-4.11.

@sloriot
Copy link
Copy Markdown
Member

sloriot commented Aug 1, 2017

I tried merging this PR in the testsuite but got some strange merge conflict. I wonder whether you forgot to rebase after the depent PR was integrated?

@sgiraudot
Copy link
Copy Markdown
Contributor Author

sgiraudot commented Aug 2, 2017

Rebasing gives me conflicts everywhere for a reason I don't understand (this is not the first time I have trouble with this, I know git rebase is supposed to be the best way to rebase on master, but I much prefer the method based on remerging the branch into a fresh master…).

I'm working on it.

@sloriot sloriot changed the base branch from master to releases/CGAL-4.11-branch August 2, 2017 07:02
@sloriot sloriot changed the base branch from releases/CGAL-4.11-branch to master August 2, 2017 07:02
sgiraudot added 16 commits August 2, 2017 14:10
@sloriot
Copy link
Copy Markdown
Member

sloriot commented Aug 3, 2017

New errors on one platform:

CGAL-4.12-Ic-5/results_afabri_x64_Cygwin-Windows8_MSVC2013-Release-32bits.txt	
+Point_set_3 n
+Point_set_3_Examples n
+Point_set_processing_3_Examples n
+Polyhedron_Demo n
+Scale_space_reconstruction_3_Examples n

@sgiraudot
Copy link
Copy Markdown
Contributor Author

sgiraudot commented Aug 4, 2017

They should be fixed now.

@sloriot
Copy link
Copy Markdown
Member

sloriot commented Aug 8, 2017

@sgiraudot must handle colors that are not encoded using int.

@sgiraudot
Copy link
Copy Markdown
Contributor Author

sgiraudot commented Aug 9, 2017

(It's the indices of the polyhedron that do not work if they are not int, colors works fine, but it's a detail.)

@sloriot sloriot self-assigned this Aug 10, 2017
@sloriot sloriot merged commit 621ddac into CGAL:master Aug 10, 2017
@sloriot sloriot deleted the Read_PLY_polygon_soup-GF branch August 10, 2017 11:47
@sgiraudot sgiraudot mentioned this pull request Aug 24, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sloriot sloriot

Labels

CGAL 3D demo tested manually on Linux Tested

Projects

None yet

Milestone

4.12-beta

Development

Successfully merging this pull request may close these issues.

IO for Polygon Soups

3 participants

@sgiraudot @lrineau @sloriot