Skip to content

update abbreviated format description#119

Merged
ahouseholder merged 1 commit intoCERTCC:mainfrom
j---:vectornotation
Mar 8, 2021
Merged

update abbreviated format description#119
ahouseholder merged 1 commit intoCERTCC:mainfrom
j---:vectornotation

Conversation

@j---
Copy link
Collaborator

@j--- j--- commented Mar 3, 2021

should close #109 and close #111

@sei-vsarvepalli
Copy link
Contributor

Hey @j---
Looks good mostly. Only question I have is on the language issue. JSON format allows for UTF-8 representation of each of "keys" and "values" in both the Provision and Computed schema. So, what should happen if language is say Japanese in UTF-8, do they pick equivalent English letters? Is SSVC vector only is limited to POSIX locale - basically US-ASCII chars only? Maybe a short note of this would be good to clarify how short notation handles languages.

Vijay

Copy link
Contributor

@ahouseholder ahouseholder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me

@ahouseholder
Copy link
Contributor

Looks good mostly. Only question I have is on the language issue. JSON format allows for UTF-8 representation of each of "keys" and "values" in both the Provision and Computed schema. So, what should happen if language is say Japanese in UTF-8, do they pick equivalent English letters? Is SSVC vector only is limited to POSIX locale - basically US-ASCII chars only? Maybe a short note of this would be good to clarify how short notation handles languages.

While I agree that i18n of the vector is an issue we should address eventually, it seems like a gap we might note in future work (i.e., #38) for now and then revisit it once we have some engagement from folks who need it. I'm in favor of cutting a new issue for internationalization of SSVC and appending this as one of the items for that issue to address.

@sei-vsarvepalli
Copy link
Contributor

Looks good mostly. Only question I have is on the language issue. JSON format allows for UTF-8 representation of each of "keys" and "values" in both the Provision and Computed schema. So, what should happen if language is say Japanese in UTF-8, do they pick equivalent English letters? Is SSVC vector only is limited to POSIX locale - basically US-ASCII chars only? Maybe a short note of this would be good to clarify how short notation handles languages.

While I agree that i18n of the vector is an issue we should address eventually, it seems like a gap we might note in future work (i.e., #38) for now and then revisit it once we have some engagement from folks who need it. I'm in favor of cutting a new issue for internationalization of SSVC and appending this as one of the items for that issue to address.

Cool - we can track it in the "internationalization" bucket.

Copy link
Contributor

@sei-vsarvepalli sei-vsarvepalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Internationalization will be addresses in an independent issue.

@ahouseholder ahouseholder merged commit 513011d into CERTCC:main Mar 8, 2021
@j--- j--- deleted the vectornotation branch March 31, 2021 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vector keys should allow more than 1 character Vector docs should specify whether parameter order and inclusion is required

3 participants