Auto initialize algorithms in DB#89
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
==========================================
+ Coverage 93.26% 93.51% +0.24%
==========================================
Files 19 19
Lines 936 971 +35
==========================================
+ Hits 873 908 +35
Misses 63 63 ☔ View full report in Codecov by Sentry. |
alhayward
reviewed
Oct 18, 2024
alhayward
left a comment
Contributor
There was a problem hiding this comment.
Nice work! Left a few quick questions & 1 suggestion. The justification for moving away from Alembic for now makes sense.
update to the basic algorithm description Co-authored-by: Alex Hayward <44384574+alhayward@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Configuring the code to optionally load in initial algorithms after the tables have been initialized. Doing so, removes our needs now for having to use a database migration tool for the near future.
Related Issues
closes #57
Additional Notes
assets/initial_algorithms.jsonwith the two existing DIBBs algorithms. We can use this for our test cases, and also initializing a new database with the data, if the INITIAL_ALGORITHMS env variable is set. This also gives customers another option for managing their algorithms, in they can write their own and set the INITIAL_ALGORITHMS env variable to load that json file.schemas.pii.Features. The blocking keys were capitalized, so making them both capitalized will hopefully reduce errors in writing the algorithm specs.<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->
Checklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process: