Add Address feature for comparisons#61
Merged
Merged
Conversation
2 tasks
cbrinson-rise8
approved these changes
Oct 3, 2024
cbrinson-rise8
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding the ability to compare on address line and also create blocking keys on it. Also making a few testing changes and fixing bugs to make the code ready for #24.
Related Issues
#24
Additional Notes
Mypy fixes
comparefunction to usemodels.Featureinstead ofmodels.FEATURE. (src/recordlinker/linking/link.py)booltofloatto allow for more granular matching results. (src/recordlinker/linking/link.py)Improvements to
Patientclass:dataproperty to update the internal state and clear the cached record. (src/recordlinker/models/mpi.py)recordproperty and its setter to usemodel_constructfor creatingPIIRecordobjects, enhancing data handling and validation. (src/recordlinker/models/mpi.py)New features:
ADDRESSas a newBlockingKeyto support blocking based on the first four characters of the address. (src/recordlinker/models/mpi.py)ADDRESSblocking key in theto_valuemethod. (src/recordlinker/models/mpi.py)<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->
Checklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process: