Skip to content

fix tuning job timeout#470

Merged
ericbuckley merged 1 commit into
mainfrom
fix/464-job-timeout
Jul 17, 2025
Merged

fix tuning job timeout#470
ericbuckley merged 1 commit into
mainfrom
fix/464-job-timeout

Conversation

@ericbuckley

@ericbuckley ericbuckley commented Jul 16, 2025

Copy link
Copy Markdown
Collaborator

Description

Fix tuning job timeout to properly cancel job if time is exceeded

Related Issues

closes #464

Additional Notes

Using asyncio.wait_for will only timeout if the calling function yields control back to the caller, typically with some IO operation. Tuning is heavily CPU bound, after the initial queries. By converting the call to run the tuning operations in a separate thread, we can still enforce a timeout if the process takes too long.

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@ericbuckley ericbuckley self-assigned this Jul 16, 2025
@ericbuckley ericbuckley added the bug Something isn't working label Jul 16, 2025
@codecov

codecov Bot commented Jul 16, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.46%. Comparing base (40bc948) to head (1a9c2a3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #470   +/-   ##
=======================================
  Coverage   98.46%   98.46%           
=======================================
  Files          41       41           
  Lines        2407     2407           
=======================================
  Hits         2370     2370           
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ericbuckley ericbuckley marked this pull request as ready for review July 16, 2025 22:44
@ericbuckley ericbuckley merged commit ff50edf into main Jul 17, 2025
17 checks passed
@ericbuckley ericbuckley deleted the fix/464-job-timeout branch July 17, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tuning job timeout not firing

2 participants