Skip to content

Add robustness error processing#467

Merged
bamader merged 1 commit into
mainfrom
catch-errors
Jul 15, 2025
Merged

Add robustness error processing#467
bamader merged 1 commit into
mainfrom
catch-errors

Conversation

@bamader

@bamader bamader commented Jul 14, 2025

Copy link
Copy Markdown
Collaborator

Description

This PR adds error handling and logger processing for a variety of issues that could be present in the MPI that might stop tuning from working properly. DB cluster structured is validated, as are request params.

Related Issues

#455

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@codecov

codecov Bot commented Jul 15, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 97.61905% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.57%. Comparing base (ec8c6c4) to head (b0dcb2a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/recordlinker/tuning/base.py 97.05% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #467      +/-   ##
==========================================
+ Coverage   98.46%   98.57%   +0.10%     
==========================================
  Files          41       41              
  Lines        2347     2379      +32     
==========================================
+ Hits         2311     2345      +34     
+ Misses         36       34       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ericbuckley
ericbuckley approved these changes Jul 15, 2025
View reviewed changes

@ericbuckley ericbuckley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @bamader

@bamader bamader merged commit d423546 into main Jul 15, 2025
16 checks passed
@bamader bamader deleted the catch-errors branch July 15, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericbuckley ericbuckley ericbuckley approved these changes

@m-goggins m-goggins Awaiting requested review from m-goggins m-goggins is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bamader @ericbuckley