Skip to content

make alembic pyproject.toml lookup dynamic#466

Merged
ericbuckley merged 3 commits into
mainfrom
fix/make-alembic-pyproject-dynamic
Jul 15, 2025
Merged

make alembic pyproject.toml lookup dynamic#466
ericbuckley merged 3 commits into
mainfrom
fix/make-alembic-pyproject-dynamic

Conversation

@ericbuckley

@ericbuckley ericbuckley commented Jul 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

Dynamically set the pyproject.toml file path for alembic based on the CWD. This allows us to run the alembic migration code even if we are not running python in the repo root directory.

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@ericbuckley ericbuckley self-assigned this Jul 14, 2025
@ericbuckley ericbuckley added the automation Automation of processes label Jul 14, 2025
@codecov

codecov Bot commented Jul 14, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.47%. Comparing base (62b2a15) to head (5b8b5c2).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #466   +/-   ##
=======================================
  Coverage   98.46%   98.47%           
=======================================
  Files          41       41           
  Lines        2347     2362   +15     
=======================================
+ Hits         2311     2326   +15     
  Misses         36       36

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ericbuckley ericbuckley marked this pull request as ready for review July 14, 2025 18:03
bamader
bamader approved these changes Jul 14, 2025
View reviewed changes

@bamader bamader left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! What a weird error to sort through 😂

Comment thread src/recordlinker/database/__init__.py
@ericbuckley ericbuckley merged commit 452bc7f into main Jul 15, 2025
16 checks passed
@ericbuckley ericbuckley deleted the fix/make-alembic-pyproject-dynamic branch July 15, 2025 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bamader bamader bamader approved these changes

@m-goggins m-goggins Awaiting requested review from m-goggins m-goggins is a code owner

Assignees

@ericbuckley ericbuckley

Labels

automation Automation of processes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ericbuckley @bamader