changing tuning match queries to return iterators#465
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #465 +/- ##
==========================================
- Coverage 98.57% 98.46% -0.12%
==========================================
Files 41 41
Lines 2394 2407 +13
==========================================
+ Hits 2360 2370 +10
- Misses 34 37 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
m-goggins
reviewed
Jul 14, 2025
Co-authored-by: Marcelle <53578688+m-goggins@users.noreply.github.com>
m-goggins
approved these changes
Jul 15, 2025
bamader
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Modify the two functions in mpi_service that return true-match and non-match pairs to be iterators. We have the potential of reducing our memory footprint by 85% if we don't store the pairs.
Related Issues
refs #456
Additional Notes
This will not resolve #456, this is just the first step of a few to get us there. There will be follow-up steps to change the prob_calc functions to accept iterators and then eventually one to change tuning/base.py::tune to process the data as iterators.
Apologies, but a lot of the changes within are just formatting changes. My editor automatically runs
ruff formatwhen I save.<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->
Checklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process: