Skip to content

fix check unit tests to alternate databases#461

Merged
ericbuckley merged 15 commits into
mainfrom
fix/check-unit-tests-different-db
Jul 9, 2025
Merged

fix check unit tests to alternate databases#461
ericbuckley merged 15 commits into
mainfrom
fix/check-unit-tests-different-db

Conversation

@ericbuckley

@ericbuckley ericbuckley commented Jul 8, 2025

Copy link
Copy Markdown
Collaborator

Description

Fix the check unit tests workflow syntax so that the appropriate TEST_DB_URI environment variables are set before tests are executed.

Additional Notes

  • update to local_server.sh to allow for an optional WORKERS argument (useful for testing tuning where we want more than 1 thread)
  • created a new get_random_function method in databases to abstract how we build random selections into our tuning queries
  • fixed a type check issue with schemas.PassRecommendation

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@ericbuckley ericbuckley self-assigned this Jul 8, 2025
@ericbuckley ericbuckley added the qa Technical improvements to increase code quality label Jul 8, 2025
@codecov

codecov Bot commented Jul 8, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.46%. Comparing base (5edf43b) to head (80d6c78).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #461   +/-   ##
=======================================
  Coverage   98.45%   98.46%           
=======================================
  Files          41       41           
  Lines        2337     2346    +9     
=======================================
+ Hits         2301     2310    +9     
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ericbuckley ericbuckley changed the title Fix/check unit tests different db fix check unit tests to alternate databases Jul 8, 2025
@ericbuckley ericbuckley marked this pull request as ready for review July 8, 2025 23:51
Comment thread scripts/example_linkage_test.sh Outdated

@m-goggins m-goggins left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment thread scripts/local_server.sh
Comment thread scripts/example_linkage_test.sh
@m-goggins m-goggins self-requested a review July 9, 2025 16:46

@bamader bamader left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, great catch!

Comment thread scripts/example_linkage_test.sh
@ericbuckley ericbuckley merged commit 62b2a15 into main Jul 9, 2025
15 checks passed
@ericbuckley ericbuckley deleted the fix/check-unit-tests-different-db branch July 9, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

qa Technical improvements to increase code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants