fix check unit tests to alternate databases#461
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #461 +/- ##
=======================================
Coverage 98.45% 98.46%
=======================================
Files 41 41
Lines 2337 2346 +9
=======================================
+ Hits 2301 2310 +9
Misses 36 36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ericbuckley
commented
Jul 9, 2025
m-goggins
reviewed
Jul 9, 2025
m-goggins
approved these changes
Jul 9, 2025
bamader
approved these changes
Jul 9, 2025
bamader
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, great catch!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the check unit tests workflow syntax so that the appropriate TEST_DB_URI environment variables are set before tests are executed.
Additional Notes
local_server.shto allow for an optional WORKERS argument (useful for testing tuning where we want more than 1 thread)get_random_functionmethod in databases to abstract how we build random selections into our tuning queries<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->
Checklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process: