Skip to content

add initial algorithms with log-odds set to 0.0#460

Merged
m-goggins merged 14 commits into
mainfrom
feature/444-dibbs-default-empty-log-odds
Jul 10, 2025
Merged

add initial algorithms with log-odds set to 0.0#460
m-goggins merged 14 commits into
mainfrom
feature/444-dibbs-default-empty-log-odds

Conversation

@m-goggins

@m-goggins m-goggins commented Jul 8, 2025

Copy link
Copy Markdown
Collaborator

Description

Added a test_algorithms.json file with all of the dibbs default values derived from LAC and added a initial_algorithms.json file with all log-odds values set to 0.0. This ensures that our tests pass by using test_algorithms.json but users are strongly encouraged to update the log odds values based on their jurisdictional data when using RL because they will all be set to 0.0 out of the box.

Related Issues

Fixes #444

Additional Notes

@codecov

codecov Bot commented Jul 8, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.46%. Comparing base (62b2a15) to head (117eb62).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #460   +/-   ##
=======================================
  Coverage   98.46%   98.46%           
=======================================
  Files          41       41           
  Lines        2347     2347           
=======================================
  Hits         2311     2311           
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@m-goggins m-goggins marked this pull request as ready for review July 9, 2025 20:32
@m-goggins m-goggins changed the title add initial algorithms add initial algorithms with log-odds set to 0.0 Jul 9, 2025
Comment thread src/recordlinker/assets/initial_algorithms.json Outdated
Comment thread .github/workflows/check_smoke_tests.yml
Comment thread .github/workflows/check_smoke_tests.yml Outdated
@m-goggins m-goggins merged commit ec8c6c4 into main Jul 10, 2025
15 checks passed
@m-goggins m-goggins deleted the feature/444-dibbs-default-empty-log-odds branch July 10, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DIBBS default with empty log-odds

2 participants