Update docker image#443
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #443 +/- ##
==========================================
+ Coverage 98.56% 98.65% +0.09%
==========================================
Files 34 38 +4
Lines 2014 2155 +141
==========================================
+ Hits 1985 2126 +141
Misses 29 29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ericbuckley
reviewed
Jun 19, 2025
m-goggins
commented
Jun 23, 2025
ericbuckley
approved these changes
Jun 23, 2025
ericbuckley
left a comment
Collaborator
There was a problem hiding this comment.
Looks great, thanks @m-goggins
bamader
approved these changes
Jun 24, 2025
bamader
left a comment
Collaborator
There was a problem hiding this comment.
Lot of stuff I had to think through here but looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the base image from
[python](python:3.12-slim)topython:3.13-alpine, which should future proof the image a bit longer with the upgrade to 3.13 and also switching to alpine should result in fewer maintenance patches.Related Issues
Fixes #440
Additional Notes
The Microsoft ODBC driver (msodbcsql18) is not available for Alpine so I replaced it with
FreeTDSandunixODBC.