Skip to content

bugfix: delete patient with keys#418

Merged
ericbuckley merged 2 commits into
mainfrom
fix/delete-patient-with-keys
Jun 10, 2025
Merged

bugfix: delete patient with keys#418
ericbuckley merged 2 commits into
mainfrom
fix/delete-patient-with-keys

Conversation

@ericbuckley

@ericbuckley ericbuckley commented Jun 9, 2025

Copy link
Copy Markdown
Collaborator

Description

Allow for deleting a Patient record that as BlockingValues.

Additional Notes

No cascade deletes are being used, so when attempting to delete a Patient record that also has BlockingValues in the database, a SQL error is raised. Explicitly deleting those BlockingValues first, allows the Patient to be deleted.

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@ericbuckley ericbuckley self-assigned this Jun 9, 2025
@ericbuckley ericbuckley added the bug Something isn't working label Jun 9, 2025
@codecov

codecov Bot commented Jun 9, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.51%. Comparing base (f6ef4bf) to head (911222b).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #418   +/-   ##
=======================================
  Coverage   98.51%   98.51%           
=======================================
  Files          33       33           
  Lines        1948     1949    +1     
=======================================
+ Hits         1919     1920    +1     
  Misses         29       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ericbuckley ericbuckley marked this pull request as ready for review June 9, 2025 19:37
@ericbuckley ericbuckley merged commit 5aacf08 into main Jun 10, 2025
17 checks passed
@ericbuckley ericbuckley deleted the fix/delete-patient-with-keys branch June 10, 2025 14:05
@ericbuckley ericbuckley added this to the v25.8.0 milestone Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants