Skip to content

fix: small updates to trigger demo workflow#391

Merged
ericbuckley merged 3 commits into
mainfrom
fix/deployment-workflow-version
Jun 9, 2025
Merged

fix: small updates to trigger demo workflow#391
ericbuckley merged 3 commits into
mainfrom
fix/deployment-workflow-version

Conversation

@ericbuckley

@ericbuckley ericbuckley commented May 27, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

Removing the "system" input, as this workflow should only every deploy Record Linker code and not QC or ECRView code. Also, changing the version input to build so users know to use a specific demo docker image build tag from the following repo, and not a branch or release number.

Additional Notes

Also removing Johanna from the CODEOWNERS file as she is moving to another team.

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@ericbuckley ericbuckley requested a review from alismx May 27, 2025 18:25
@ericbuckley ericbuckley marked this pull request as ready for review May 27, 2025 18:25
@codecov

codecov Bot commented May 27, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.51%. Comparing base (9b4e14c) to head (7ab1452).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #391   +/-   ##
=======================================
  Coverage   98.51%   98.51%           
=======================================
  Files          33       33           
  Lines        1948     1948           
=======================================
  Hits         1919     1919           
  Misses         29       29

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

m-goggins
m-goggins approved these changes May 27, 2025
View reviewed changes

@m-goggins m-goggins left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@alismx

alismx commented May 27, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

It loooks good to me, but can we hold off on making any changes to this for your project? Just until we reach a point where we've got all projects up and deployable in demo. I still may have to make changes to all triggers across all projects and this workflow has been templatized and was designed to be used by all dibbs repos to trigger deployments. We have a lot of moving parts to get demo going right now, and it would be helpful to DevOps if we could stick with the standard that we've tested across all projects.

@ericbuckley

ericbuckley commented May 27, 2025

Copy link
Copy Markdown
Collaborator Author

It loooks good to me, but can we hold off on making any changes to this for your project? Just until we reach a point where we've got all projects up and deployable in demo. I still may have to make changes to all triggers across all projects and this workflow has been templatized and was designed to be used by all dibbs repos to trigger deployments. We have a lot of moving parts to get demo going right now, and it would be helpful to DevOps if we could stick with the standard that we've tested across all projects.

Yeah, I can hold off. Could you maybe provide some more details in the files changed tab to show which changes could cause problems?

@ericbuckley ericbuckley merged commit 389912c into main Jun 9, 2025
15 checks passed
@ericbuckley ericbuckley deleted the fix/deployment-workflow-version branch June 9, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@m-goggins m-goggins m-goggins approved these changes

@alismx alismx Awaiting requested review from alismx

@bamader bamader Awaiting requested review from bamader bamader is a code owner

@johanna-skylight johanna-skylight Awaiting requested review from johanna-skylight

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ericbuckley @alismx @m-goggins