Skip to content

Upgrade testing framework#385

Merged
bamader merged 1 commit into
mainfrom
better-data
May 22, 2025
Merged

Upgrade testing framework#385
bamader merged 1 commit into
mainfrom
better-data

Conversation

@bamader

@bamader bamader commented May 21, 2025

Copy link
Copy Markdown
Collaborator

Description

This PR provides an overhaul and update to the Record Linker algorithm match performance testing suite. It provides a robust new source of testing data--combining regraded NBS cases with new cases designed to test feature missingness and data quality limitations, as well as corrects a deficiency in our existing seed file where the last digit of SSN was getting chopped off. The new included README summarizes the purpose of different testing files, but for more details on the actual development plan and interpretation of new testing results, see the associated document.

Related Issues

Closes #368

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@codecov

codecov Bot commented May 21, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.51%. Comparing base (210f706) to head (3a4bd64).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #385   +/-   ##
=======================================
  Coverage   98.51%   98.51%           
=======================================
  Files          33       33           
  Lines        1948     1948           
=======================================
  Hits         1919     1919           
  Misses         29       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ericbuckley ericbuckley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work

Comment thread tests/algorithm/data/README.md
@bamader bamader merged commit 0cfa3d7 into main May 22, 2025
16 checks passed
@bamader bamader deleted the better-data branch May 22, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create human-graded expanded test case set from NBS base cases

2 participants