Skip to content

remove context from results in algorithm list#369

Merged
ericbuckley merged 1 commit into
mainfrom
feature/algo-list-remove-context
May 15, 2025
Merged

remove context from results in algorithm list#369
ericbuckley merged 1 commit into
mainfrom
feature/algo-list-remove-context

Conversation

@ericbuckley

@ericbuckley ericbuckley commented May 13, 2025

Copy link
Copy Markdown
Collaborator

Description

The algorithm context was never meant to be in the results of the listing API call, this call is supposed to just give high level details of what algorithms are available. The specific detail API endpoints for each algorithm, should be used to get info on the algorithm context and/or the passes.

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

The algorithm context was never meant to be in the results of the
listing API call, this call is supposed to just give high level details
of what algorithms are available.  The specific detail API endpoints for
each algorithm, should be used to get info on the algorithm context
and/or the passes.
@ericbuckley ericbuckley self-assigned this May 13, 2025
@ericbuckley ericbuckley added the api New API feature label May 13, 2025
@codecov

codecov Bot commented May 13, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.51%. Comparing base (4c60446) to head (8322269).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #369   +/-   ##
=======================================
  Coverage   98.51%   98.51%           
=======================================
  Files          33       33           
  Lines        1947     1948    +1     
=======================================
+ Hits         1918     1919    +1     
  Misses         29       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ericbuckley ericbuckley marked this pull request as ready for review May 13, 2025 21:30

@bamader bamader left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh lol good catch

@ericbuckley ericbuckley merged commit 9587a55 into main May 15, 2025
17 checks passed
@ericbuckley ericbuckley deleted the feature/algo-list-remove-context branch May 15, 2025 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api New API feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants