Skip to content

Add feature medians#355

Merged
bamader merged 1 commit into
mainfrom
link-result-context
May 6, 2025
Merged

Add feature medians#355
bamader merged 1 commit into
mainfrom
link-result-context

Conversation

@bamader

@bamader bamader commented May 6, 2025

Copy link
Copy Markdown
Collaborator

Description

This PR adds feature median scores to the LinkResult class for purposes of data reporting. The feature medians are stored in a dictionary on the LinkResult so they can be accessed by feature name by a user who wishes to see how much of the total log odds points for a match came from a particular feature. Testing has been updated where relevant to verify feature medians are accurately generated for non-matches, matches, and missing information.

Related Issues

Closes #264

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@codecov

codecov Bot commented May 6, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.51%. Comparing base (a8003bb) to head (315e574).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #355   +/-   ##
=======================================
  Coverage   98.50%   98.51%           
=======================================
  Files          33       33           
  Lines        1937     1947   +10     
=======================================
+ Hits         1908     1918   +10     
  Misses         29       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@m-goggins m-goggins left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bamader bamader merged commit 1b961c8 into main May 6, 2025
16 checks passed
@bamader bamader deleted the link-result-context branch May 6, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add user reporting to the LinkResult class

2 participants