Skip to content

Handle suffix during evaluation#346

Merged
bamader merged 1 commit into
mainfrom
suffix-evaluation
May 2, 2025
Merged

Handle suffix during evaluation#346
bamader merged 1 commit into
mainfrom
suffix-evaluation

Conversation

@bamader

@bamader bamader commented May 1, 2025

Copy link
Copy Markdown
Collaborator

Description

This PR adds the final piece of handling suffixes during name evaluation. Previously, we used them only during blocking, but this change set now includes handling during evaluation as well. In order to still maintain the First_Name field as its own readable entity, we've simply re-used the should-prepend parameter in feature_iter. That way, it's only during the very specific cases we've outlined that we combine a name and a suffix.

Related Issues

Closes #299

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@codecov

codecov Bot commented May 1, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.11%. Comparing base (2d055ce) to head (645e410).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #346   +/-   ##
=======================================
  Coverage   98.11%   98.11%           
=======================================
  Files          33       33           
  Lines        1958     1958           
=======================================
  Hits         1921     1921           
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@m-goggins m-goggins left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Comment thread tests/unit/linking/test_link.py
Comment thread tests/unit/linking/test_link.py
@bamader

bamader commented May 1, 2025

Copy link
Copy Markdown
Collaborator Author

Ran the algorithm match tests just to see, and we caught one more true positive because we now handle Jr/Sr edge cases:

Results:
32.0 true positives correctly identified
15.0 true negatives correctly identified
2.0 false positives misidentified
21.0 false negatives misidentified

Sensitivity: 0.6037735849056604
Specificity: 0.8823529411764706
F1-Score: 0.735632183908046
PPV: 0.9411764705882353

Possible Matches, NBS Perspective
3.0 NBS-labelled possible matches we graded 'certain'
7.0 NBS-labelled possible matches we graded 'certainly-not'
0.0 NBS-labelled possible matches we graded 'possible-match'

Possible Matches, DIBBs Perspective
0.0 DIBBs-labelled possible matches NBS graded 'certain'
0.0 DIBBs-labelled possible matches NBS graded 'certainly-not'
0.0 DIBBs-labelled possible matches NBS graded 'possible-match'

@bamader bamader merged commit efa65db into main May 2, 2025
16 checks passed
@bamader bamader deleted the suffix-evaluation branch May 2, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement FULL_FIRST_NAME FeatureAttribute

2 participants