Skip to content

adding ghcr.io vulnerability scan job#345

Merged
ericbuckley merged 9 commits into
mainfrom
qa/ghcr-scan-job
May 2, 2025
Merged

adding ghcr.io vulnerability scan job#345
ericbuckley merged 9 commits into
mainfrom
qa/ghcr-scan-job

Conversation

@ericbuckley

@ericbuckley ericbuckley commented May 1, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

Creating a job to scan the latest docker image in ghcr.io for vulnerabilities daily. Scanning during building only partly solves the problem, as many of the vulnerabilities can be found after a release has already been shipped.

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@ericbuckley ericbuckley added the qa Technical improvements to increase code quality label May 1, 2025
@ericbuckley ericbuckley self-assigned this May 1, 2025
@codecov

codecov Bot commented May 1, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.11%. Comparing base (ee86cca) to head (51b6c76).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #345   +/-   ##
=======================================
  Coverage   98.11%   98.11%           
=======================================
  Files          33       33           
  Lines        1958     1958           
=======================================
  Hits         1921     1921           
  Misses         37       37

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-advanced-security

github-advanced-security AI commented May 1, 2025

Copy link
Copy Markdown

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@ericbuckley ericbuckley marked this pull request as ready for review May 1, 2025 19:55
johanna-skylight
johanna-skylight approved these changes May 1, 2025
View reviewed changes

@johanna-skylight johanna-skylight left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ericbuckley ericbuckley merged commit 37bb71c into main May 2, 2025
15 checks passed
@ericbuckley ericbuckley deleted the qa/ghcr-scan-job branch May 2, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johanna-skylight johanna-skylight johanna-skylight approved these changes

@bamader bamader Awaiting requested review from bamader bamader is a code owner

@m-goggins m-goggins Awaiting requested review from m-goggins m-goggins is a code owner

Assignees

@ericbuckley ericbuckley

Labels

qa Technical improvements to increase code quality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ericbuckley @github-advanced-security @johanna-skylight