Add stats calculations and results display#342
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #342 +/- ##
==========================================
- Coverage 98.23% 98.11% -0.13%
==========================================
Files 33 33
Lines 1924 1958 +34
==========================================
+ Hits 1890 1921 +31
- Misses 34 37 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ericbuckley
reviewed
May 1, 2025
ericbuckley
reviewed
May 1, 2025
ericbuckley
approved these changes
May 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is a fast-follow to a conversation had on 4/30 in which we established we wanted a standardized performance calculation script to be uploaded to our repo. This script integrates into the
run_test.pyscript executed as part of algorithm tests, and gives us calculations for: raw counting stats (TP, FP, TN, FN), derived match quality stats (sens, spec, F1, PPV), and labels for matches graded possible by either system. This should standardize the way we calculate and report performance going forward.NOTE: The change numbers look massive, but that's because we got the all-clear to upload our more robust test and seed data sets into the algorithm test configuration. There are only a couple changed code files, most of this is CSV uploading.
<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->
Checklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process: