Skip to content

fixes for the performance scripts#340

Merged
ericbuckley merged 1 commit into
mainfrom
qa/performance-scripts-fixes
May 1, 2025
Merged

fixes for the performance scripts#340
ericbuckley merged 1 commit into
mainfrom
qa/performance-scripts-fixes

Conversation

@ericbuckley

@ericbuckley ericbuckley commented Apr 30, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

Fixes to the variables in the performance scripts to account for changes to API.

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@ericbuckley ericbuckley added the qa Technical improvements to increase code quality label Apr 30, 2025
@ericbuckley ericbuckley self-assigned this Apr 30, 2025
@ericbuckley ericbuckley marked this pull request as ready for review April 30, 2025 19:39
@codecov

codecov Bot commented Apr 30, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.23%. Comparing base (952a4da) to head (0608755).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #340   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files          33       33           
  Lines        1924     1924           
=======================================
  Hits         1890     1890           
  Misses         34       34

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

m-goggins
m-goggins reviewed May 1, 2025
View reviewed changes
Comment thread tests/performance/rlpt.env
@m-goggins m-goggins self-requested a review May 1, 2025 15:25
@ericbuckley ericbuckley merged commit ee86cca into main May 1, 2025
@ericbuckley ericbuckley deleted the qa/performance-scripts-fixes branch May 1, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@m-goggins m-goggins m-goggins approved these changes

@bamader bamader Awaiting requested review from bamader bamader is a code owner

Assignees

@ericbuckley ericbuckley

Labels

qa Technical improvements to increase code quality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ericbuckley @m-goggins