Skip to content

Define default skip values, update test data#338

Merged
bamader merged 1 commit into
mainfrom
define-default-skips
Apr 30, 2025
Merged

Define default skip values, update test data#338
bamader merged 1 commit into
mainfrom
define-default-skips

Conversation

@bamader

@bamader bamader commented Apr 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

This PR defines some default skip values for the DIBBs algorithm and adds them to both the initial algorithm file and the file used for testing. It also updates the compose file that spins up the algorithm tests in docker, which was missing the /api addition when we configured the base URL.

Related Issues

Closes #333

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@codecov

codecov Bot commented Apr 29, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.23%. Comparing base (7046004) to head (a667d74).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #338   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files          33       33           
  Lines        1924     1924           
=======================================
  Hits         1890     1890           
  Misses         34       34

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ericbuckley
ericbuckley reviewed Apr 30, 2025
View reviewed changes
Comment thread compose.yml
@bamader bamader force-pushed the define-default-skips branch from 10f5c35 to a667d74 Compare April 30, 2025 13:58
@bamader bamader requested a review from ericbuckley April 30, 2025 13:58
ericbuckley
ericbuckley approved these changes Apr 30, 2025
View reviewed changes

@ericbuckley ericbuckley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks Brandon!

@bamader bamader merged commit 952a4da into main Apr 30, 2025
@bamader bamader deleted the define-default-skips branch April 30, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericbuckley ericbuckley ericbuckley approved these changes

@m-goggins m-goggins Awaiting requested review from m-goggins m-goggins is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Identify appropriate initial skip values for DIBBs default

2 participants

@bamader @ericbuckley