Algorithm context advanced section#334
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #334 +/- ##
==========================================
+ Coverage 98.11% 98.51% +0.40%
==========================================
Files 33 33
Lines 1958 1948 -10
==========================================
- Hits 1921 1919 -2
+ Misses 37 29 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bamader
reviewed
May 1, 2025
bamader
left a comment
Collaborator
There was a problem hiding this comment.
Logic all looks good! Just some comments around names and possible parameter standardization, but they're small things and this is just about there.
bamader
approved these changes
May 2, 2025
bamader
left a comment
Collaborator
There was a problem hiding this comment.
Looks good--thanks for the back and forth on this! This cleanup refactor is really starting to come together 💪
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Create algorithm advanced section,
algorithm.context.advanced, to store parameters that we advise users to change with caution. All of these parameters will now come with recommended default values.Related Issues
closes #296
<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->
Checklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process: