schema.AlgorithmContext#330
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #330 +/- ##
==========================================
- Coverage 98.23% 98.11% -0.13%
==========================================
Files 33 33
Lines 1924 1958 +34
==========================================
+ Hits 1890 1921 +31
- Misses 34 37 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ericbuckley
commented
Apr 25, 2025
bamader
reviewed
Apr 29, 2025
bamader
left a comment
Collaborator
There was a problem hiding this comment.
Sorry for the delay on getting back to this--for whatever reason it just took me a while to wrap my head around the validation layer on top of the caching layer on top of the dictionary. I think everything makes logical sense to me, just a few outstanding questions to clear up on my part!
bamader
previously approved these changes
Apr 30, 2025
bamader
left a comment
Collaborator
There was a problem hiding this comment.
Questions have been cleared up so giving the +1 to merge!
bamader
approved these changes
Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Create AlgorithmContext nested schema object to store include_multiple_results, log_odds and skip_values.
Related Issues
closes #293
Additional Notes
The
max_log_odds_pointsparameter was removed from the compare method. It's still required in the function, but now we need to retrieve the log_odds value for a feature BEFORE we call the matcher function (previously the matcher functions were retrieving this from the kwargs). Since we're doing that in compare, it seemed simple enough to just make that a calculated value (summations are simple and quick).<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->
Checklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process: