Skip to content

Prepend during blocking#327

Merged
bamader merged 2 commits into
mainfrom
prepend_name_blocking
Apr 24, 2025
Merged

Prepend during blocking#327
bamader merged 2 commits into
mainfrom
prepend_name_blocking

Conversation

@bamader

@bamader bamader commented Apr 23, 2025

Copy link
Copy Markdown
Collaborator

Description

This PR prepends normalized suffixes to first names during blocking. Following the convention of the existing feature_iter entry for First Name, only the first suffix is pulled, and only if it has been normalized as a result of parsing. The least invasive way I found to make this change was an optional boolean flag on feature_iter proper, since otherwise in the blocking keys call we can't call feature_iter on First Name and have to basically repeat / reconstruct that code, but if that's preferable that's also okay with me.

Related Issues

Closes #298

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@codecov

codecov Bot commented Apr 23, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.17%. Comparing base (2cacd8d) to head (b92502c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #327   +/-   ##
=======================================
  Coverage   98.16%   98.17%           
=======================================
  Files          32       32           
  Lines        1853     1858    +5     
=======================================
+ Hits         1819     1824    +5     
  Misses         34       34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ericbuckley ericbuckley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @bamader, would you mind updating the FIRST_NAME blocking key documentation in docs/site/reference.md with additional info about prepending the suffix if it exists?

@bamader

bamader commented Apr 24, 2025

Copy link
Copy Markdown
Collaborator Author

For sure, can add that!

@bamader bamader merged commit 6e7863a into main Apr 24, 2025
@bamader bamader deleted the prepend_name_blocking branch April 24, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prepend FIRST_NAME Blocking Keys with Normalized Suffixes

2 participants