Skip to content

remove models.AlgorithmPass#326

Merged
ericbuckley merged 1 commit into
mainfrom
feature/292-remove-algo-pass-model
Apr 24, 2025
Merged

remove models.AlgorithmPass#326
ericbuckley merged 1 commit into
mainfrom
feature/292-remove-algo-pass-model

Conversation

@ericbuckley

@ericbuckley ericbuckley commented Apr 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

Remove models.AlgorithmPass and store the data as a JSON list on the models.Algorithm

Related Issues

closes #292

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@ericbuckley ericbuckley self-assigned this Apr 23, 2025
@codecov

codecov Bot commented Apr 23, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.10%. Comparing base (f54a090) to head (f01bfce).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #326      +/-   ##
==========================================
- Coverage   98.15%   98.10%   -0.05%     
==========================================
  Files          32       32              
  Lines        1838     1792      -46     
==========================================
- Hits         1804     1758      -46     
  Misses         34       34

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ericbuckley ericbuckley marked this pull request as ready for review April 23, 2025 04:01
m-goggins
m-goggins approved these changes Apr 24, 2025
View reviewed changes

@m-goggins m-goggins left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ericbuckley ericbuckley merged commit 7046004 into main Apr 24, 2025
@ericbuckley ericbuckley deleted the feature/292-remove-algo-pass-model branch April 24, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@m-goggins m-goggins m-goggins approved these changes

@bamader bamader Awaiting requested review from bamader bamader is a code owner

Assignees

@ericbuckley ericbuckley

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

remove models.AlgorithmPass

2 participants

@ericbuckley @m-goggins