Add suffix normalization#322
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #322 +/- ##
==========================================
+ Coverage 98.15% 98.16% +0.01%
==========================================
Files 32 32
Lines 1838 1853 +15
==========================================
+ Hits 1804 1819 +15
Misses 34 34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ericbuckley
reviewed
Apr 22, 2025
ericbuckley
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This changeset adds a pydantic validator that parses and normalizes suffixes according to a predefined mapping. I've left the mapping in an assets file in case we want to add roman numeral standardization at some later date.
Related Issues
Fixes #297
Additional Notes
I did some research on common suffixes in names in the US, and most results indicated it's pretty limited, just Junior, Senior, II, and III. It's easy to support roman numerals, as well as any other spelling or punctuated variants thereof, but given this I think leaving the suffixes we intend to support in an assets file (like with state abbreviations and street conventions) follows our established practice.
<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->
Checklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process: