configurable API root path#320
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #320 +/- ##
==========================================
+ Coverage 98.25% 98.26% +0.01%
==========================================
Files 33 33
Lines 1946 1965 +19
==========================================
+ Hits 1912 1931 +19
Misses 34 34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bamader
previously approved these changes
Apr 21, 2025
bamader
left a comment
Collaborator
There was a problem hiding this comment.
Everything looks good! Just have a question about what parts of the app we're specifically trying to situate behind the /api tag, but it's non-blocking so giving the +1.
bamader
approved these changes
Apr 24, 2025
bamader
left a comment
Collaborator
There was a problem hiding this comment.
Looks good and works on my local 💪
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding a configuration setting to change the root path of the API
Related Issues
closes #287
Additional Notes
[Add any additional context or notes that reviewers should know about.]
<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->
Checklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process: