new schema mpi fuctions#30
Merged
Merged
Conversation
alhayward
reviewed
Sep 19, 2024
alhayward
left a comment
Contributor
There was a problem hiding this comment.
Great work! This makes the code much more readable, and I appreciate the attention to detail in testing.
10 tasks
alhayward
previously approved these changes
Sep 24, 2024
alhayward
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thank you for your detailed responses 🙌🏼 Appreciate your thoughts on the ways we can optimize the algorithm!
…key value is missing
cbrinson-rise8
approved these changes
Sep 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implementing the MPI functions,
get_block_dataandinsert_matched_patient, using the new schema.Related Issues
closes #10
Additional Notes
settings.db_urinow has the information that we used dotenv to load, so we don't need this anymoreChecklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process: