Skip to content

adding skip values to algorithm#280

Merged
ericbuckley merged 2 commits into
mainfrom
feature/232-algorithm-skip-values
Apr 14, 2025
Merged

adding skip values to algorithm#280
ericbuckley merged 2 commits into
mainfrom
feature/232-algorithm-skip-values

Conversation

@ericbuckley

@ericbuckley ericbuckley commented Apr 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

Add skip_values to Algorithm configuration.

Related Issues

closes #232

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@ericbuckley ericbuckley self-assigned this Apr 8, 2025
@codecov

codecov Bot commented Apr 8, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.08%. Comparing base (10deb83) to head (4c169b1).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #280      +/-   ##
==========================================
+ Coverage   98.06%   98.08%   +0.01%     
==========================================
  Files          32       32              
  Lines        1813     1827      +14     
==========================================
+ Hits         1778     1792      +14     
  Misses         35       35

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ericbuckley ericbuckley marked this pull request as ready for review April 10, 2025 23:13
bamader
bamader approved these changes Apr 14, 2025
View reviewed changes

@bamader bamader left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ericbuckley ericbuckley merged commit c5b0589 into main Apr 14, 2025
@ericbuckley ericbuckley deleted the feature/232-algorithm-skip-values branch April 14, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bamader bamader bamader approved these changes

@m-goggins m-goggins Awaiting requested review from m-goggins m-goggins is a code owner

Assignees

@ericbuckley ericbuckley

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Algorithm to accept a skip_values attribute

2 participants

@ericbuckley @bamader