Skip to content

NAME feature#279

Merged
ericbuckley merged 2 commits into
mainfrom
feature/234-name
Apr 14, 2025
Merged

NAME feature#279
ericbuckley merged 2 commits into
mainfrom
feature/234-name

Conversation

@ericbuckley

@ericbuckley ericbuckley commented Apr 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

Adding the NAME feature for matching. Its primary use case will be for future skip values.

Related Issues

closes #234

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@ericbuckley ericbuckley self-assigned this Apr 8, 2025
@codecov

codecov Bot commented Apr 8, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.95%. Comparing base (ab93ddc) to head (f87ac83).
Report is 7 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #279   +/-   ##
=======================================
  Coverage   97.94%   97.95%           
=======================================
  Files          33       33           
  Lines        1804     1808    +4     
=======================================
+ Hits         1767     1771    +4     
  Misses         37       37

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ericbuckley ericbuckley marked this pull request as ready for review April 10, 2025 23:11
m-goggins
m-goggins approved these changes Apr 11, 2025
View reviewed changes

@m-goggins m-goggins left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ericbuckley ericbuckley merged commit ff1579a into main Apr 14, 2025
@ericbuckley ericbuckley deleted the feature/234-name branch April 14, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bamader bamader bamader approved these changes

@m-goggins m-goggins m-goggins approved these changes

Assignees

@ericbuckley ericbuckley

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NAME feature

3 participants

@ericbuckley @bamader @m-goggins