dynamic next urls for patient/person routers#276
Merged
Conversation
removing the hard-coded next url paths for our orphaned patient and person routes, and replacing with versions that are dynamically generated. The work on the roadshow concept is requiring us to reorganize our API url paths, which will in effect change the path for both of these routes. Doing this dynmically makes it easier to encapsulate all those url path changes in main.py.
Collaborator
Author
|
@johanna-skylight merging this change should address the failed tests you're seeing in the monorepo branch |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #276 +/- ##
=======================================
Coverage 97.92% 97.92%
=======================================
Files 33 33
Lines 1787 1787
=======================================
Hits 1750 1750
Misses 37 37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
m-goggins
approved these changes
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
removing the hard-coded next url paths for our orphaned patient and person routes, and replacing with versions that are dynamically generated. The work on the roadshow concept is requiring us to reorganize our API url paths, which will in effect change the path for both of these routes. Doing this dynamically makes it easier to encapsulate all those url path changes in main.py.
<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->
Checklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process: