Feature/223 simplify function calls#275
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #275 +/- ##
==========================================
- Coverage 97.92% 97.78% -0.15%
==========================================
Files 33 32 -1
Lines 1787 1757 -30
==========================================
- Hits 1750 1718 -32
- Misses 37 39 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
m-goggins
approved these changes
Apr 8, 2025
m-goggins
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for breaking this up into smaller pieces! This looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Simplify algorithm configuration feature function syntax and remove algorithm pass rule.
Related Issues
refs #223
Additional Notes
The algorithm configuration function syntax (ie "func:recordlinker.linking.matchers...") doesn't need to be so complex. Users don't need to know where the function lives, they just need to know what it does.
The rule doesn't need to be a variable anymore, as there is only one value users can pick from.
<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->
Checklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process: