Description

Removing the circular dependency between models/mpi.py and schemas/pii.py. pii.py now depends on mpi.py, but not vice-versa.

Related Issues

closes #176

Additional Notes

The circular dependency didn't cause any issues, as the mpi.py module imported all of its pii.py dependencies in functions rather than at the top of the module, but this is a hack. Having two modules depend on each other opens potentials for errors during refactors, or could lead to more spaghetti code if attempt to use PIIRecord in mpi.py for other uses.

• pii.PIIRecord created 2 new methods for converting a Patient into a PIIRecord and back. PIIRecord.from_patient and PIIRecord.to_data.
• To reduce the number of times in which we convert a Patient object to a PIIRecord, the matching function signatures have been updated to accept two PIIRecord for comparison, rather than a PIIRecord and Patient.

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

• I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
• I have reviewed my changes to ensure they are clear, concise, and well-documented.
• I have updated the documentation, if applicable.
• I have added or updated test cases to cover my changes, if applicable.
• I have minimized the number of reviewers to include only those essential for the review.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

• The code follows best practices and conventions.
• The changes implement the desired functionality or fix the reported issue.
• The tests cover the new changes and pass successfully.
• Any potential edge cases or error scenarios have been considered.