normalize telecom model_validator#269
Merged
Merged
Conversation
5 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #269 +/- ##
==========================================
- Coverage 97.84% 97.83% -0.01%
==========================================
Files 33 33
Lines 1807 1805 -2
==========================================
- Hits 1768 1766 -2
Misses 39 39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ericbuckley
reviewed
Mar 31, 2025
ericbuckley
requested changes
Mar 31, 2025
ericbuckley
reviewed
Apr 1, 2025
…ature/248-validate-and-normalize-telecom-data
ericbuckley
reviewed
Apr 1, 2025
ericbuckley
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a model validator to the
Telecomclass that strips leading/trailing whitespace from emails and normalizes phone as an E164 string, i.e., including country codes but excluding extensions. When usingfeature_iter, only the national number (no country code) is used for comparison to avoid issues with Jaro-Winkler over indexing on similarities in country codes. For emails, we do not apply text normalization infeature_iterso that we can preserve the special characters for comparison.Storing:
Comparing:
-email: same as storage
phone number: national number (no country code) and normalized_text() is applied to remove additional special characters. I primarily kept normalized_text in case we were not able to normalize to E164 during ingestion and we want to remove special characters.
Related Issues
Fixes #248
Additional Notes
<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->
Checklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process: