address line suffix normalize#258
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #258 +/- ##
==========================================
+ Coverage 97.85% 97.86% +0.01%
==========================================
Files 33 33
Lines 1770 1780 +10
==========================================
+ Hits 1732 1742 +10
Misses 38 38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ericbuckley
commented
Mar 25, 2025
m-goggins
reviewed
Mar 26, 2025
bamader
approved these changes
Mar 26, 2025
bamader
left a comment
Collaborator
There was a problem hiding this comment.
This one looks good to go, but I left a note about wanting to revisit formatting, preprocessing, and additional input sanitization points down the road. I think they're small things we can do to boost robustness and piece of mind in the (probably likely) event that improperly formatted or odd-valued raw data gets attempted to be submitted. It's also likely got value when we think about standalone solutions so that we're more fault tolerant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a normalization step for normalizing street suffixes and updating the state normalization process to happen during ingestion.
Related Issues
closes #239
Additional Notes
Previously, state values were being normalized in the feature_iter. In alignment with the direction we're taking on the other fields, it makes sense to do this normalization just once, at ingestion time. One key difference with this, is we are now preserving any invalid state values, mainly to preserve data when a state could be misspelled.
<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->
Checklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process: